[Github-comments] [geany/geany-plugins] pretty-printer: added saving and loading of preferences in/from a file. Fixes #494. (#581)

Anthony Loiseau notifications at xxxxx
Sat Jun 17 15:44:45 UTC 2017


Thannoy commented on this pull request.



> +
+    kf = g_key_file_new ();
+
+    if (!g_key_file_load_from_data (kf, contents, size,
+             G_KEY_FILE_KEEP_COMMENTS | G_KEY_FILE_KEEP_TRANSLATIONS,
+             error))
+    {
+        g_key_file_free (kf);
+        return FALSE;
+    }
+
+    if (g_key_file_has_key (kf, "pretty-printer", "newLineChars", NULL))
+    {
+        if (ppo->newLineChars != NULL )
+        {
+            g_free ((gpointer)ppo->newLineChars);

(minor) same as above, you can use g_free unconditionally here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/581#pullrequestreview-44702741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170617/4debbbe0/attachment.html>


More information about the Github-comments mailing list