[Github-comments] [geany/geany] Add an editor option to enable IME's candidate window display inline (#1514)

[elextr]

elextr commented on this pull request.



> @@ -5172,6 +5172,9 @@ void editor_apply_update_prefs(GeanyEditor *editor)
 	/* virtual space */
 	SSM(sci, SCI_SETVIRTUALSPACEOPTIONS, editor_prefs.show_virtual_space, 0);
 
+	/* input method editor's candidate window behaviour */
+	SSM(sci, SCI_SETIMEINTERACTION, editor_prefs.ime_interaction, 0);
+

The current situation is that no IME interaction is set, unless you can be sure that setting an interaction has no effect anywhere else, then not setting it at all should be the default.  

So you can use your boolean and put this in an if.  That would also actually match your documentation above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1514#pullrequestreview-43307710
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170610/1d31c59a/attachment.html>