[Github-comments] [geany/geany] editor: fix incorrect variable reference (#1561)

Matthew Brush notifications at xxxxx
Thu Jul 27 01:35:09 UTC 2017


@elextr why should a comment on a line in the diff (not a "review" comment even), specifically stating that I know it's not caused by this PR (neither @b4n nor I said it was _unrelated_), stall the PR, even though I made a point of adding a PR-level comment that it looks OK? The thing that stalls (or at least confuses) PRs is off-topic discussion in the PR-level thread (like this).

Moreover, if a bug is noticed within a few lines, and directly affected by the changes in the PR, it's not really a separate issue/PR (PRs can have more than one commit), if the pull requester feels like fixing the code in the same PR, seeing as it touches the same code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1561#issuecomment-318231655
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170727/11713709/attachment.html>


More information about the Github-comments mailing list