[Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

[Vasiliy Faronov]

@kugel- 

> An assert carries the intent to say "if this is null, then there is a programming error elsewhere"

Right, but so does simply dereferencing `doc` in the very next line. There is no deeper meaning to our `doc != NULL` requirement: we need it only insofar as we need to get to `doc->file_name`. That’s why I don’t see this (without an `if (doc)` guard) as a very good use case for an assertion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-315527789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170715/cd8ddf20/attachment.html>