[Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

[Thomas Martitz]

There is https://github.com/geany/geany-plugins/issues/433 which I could easily reproduce. This is fixed by this patch.

I still think it should be attempted to become a normal callback again, it seems wasteful to keep a 50ms timer running indefinitely. Here is @zhekov reply to that:

> The empty gio IN-s for a channel seem to start as soon as data appears on that channel, and never end. Or, they may end after some unpredictable time (minutes or more), when the spawn client finally manages to read all data, and the 50ms timeouts will do that fast. But I have no reason to believe that the empty IN-s won't start again as soon as unread data appears on the channel

That sounds to me as if we could switch to the timer only when there is data and go to the normal callback in idle periods. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#issuecomment-314978639
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170712/ec996fe4/attachment.html>