[Github-comments] [geany/geany] Theme improvements (#1382)

[Colomban Wendling]

b4n commented on this pull request.



> +	theme_fn = g_build_filename(app->datadir, "geany.css", NULL);
+	load_css_theme(theme_fn, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
+	g_free(theme_fn);
+
+	// load themes to handle breakage between various GTK+ versions
+	const struct
+	{
+		guint min_version;
+		guint max_version;
+		const gchar *file;
+	}
+	css_files[] =
+	{
+		{ 20, G_MAXUINT, "geany-3.20.css" },
+		{ 0, 19, "geany-3.0.css" },
+	};

I like `@import`ing because it gives the flexibility when writing the style.  But OTOH as we don't try and load `geany-$(gtk_version).css` new specific style mean code change, so I don't mind either.

I would revert it because I liked it and it proven itself working, but it you prefer it like that I fine with it too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1382
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170130/5719b524/attachment.html>