[Github-comments] [geany/geany] Themable compiler output in message window (#1377)

[Benjamin Heiniger]

I actually didn't realize that there was already the option to customize some colors using the GTK theme, which is why I did it using colorschemes. 

I agree that using the GTK theme would be better, as it is more consistent with how geany works at the moment (-> as codebrainz pointed out: colorschemes for the editor, gtkrc for the other widgets). While it is true that no theme will provide the colors for those specific styles, this is also the case for all the other widgets that are at styled using geany.gtkrc (tab foregrounds, etc).

Additionally, the current implementation only changes the foreground color according to the colorscheme, whereas the background color is still defined by GTK, meaning that using a dark colorscheme and a light GTK theme or vice versa will again lead to unreadable messages.

I changed the fix to load the colors from the GTK theme, should I make a new pull request for it or update this one?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1377#issuecomment-275708703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170127/4bb597d5/attachment.html>