[Github-comments] [geany/geany] Snippets accelerator callback appears to be the wrong prototype. (#1354)

[elextr]

Snippet keybindings use `on_snippet_keybinding_activate()` as the [callback](https://github.com/geany/geany/blob/master/src/editor.c#L242) and it returns [void](https://github.com/geany/geany/blob/master/src/editor.c#L194) but the callback should return [boolean](https://developer.gnome.org/gtk3/stable/gtk3-Keyboard-Accelerators.html#GtkAccelGroupActivate).

This may account for the observation in #1353 that Scintilla keybindings are activated as well as the snippet, since the callback does not return true to prevent further signal emissions.

"Somebody" who knows GTK as well as @b4n should check my logic :smile:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1354
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170103/ad7e6690/attachment.html>