[Github-comments] [geany/geany] Fix search history filling on GTK >= 3.20 (#1404)

[Colomban Wendling]

Since GTK 3.19.12, GtkComboBox has an intermediate GtkBox internal child wrapping the inner GtkEntry.  To get the entry, `gtk_bin_get_child()` still works as it is part of the API, but the
change breaks the assumption we had that it works the other way around, that `gtk_widget_get_parent(gtk_bin_get_child(combobox)) == combobox`. So, while this assumption seemed reasonable, stop relying on it as it is effectively not correct on GTK 3.20 and newer.

See: https://git.gnome.org/browse/gtk+/commit/?id=222c43fc60362eeb97ce2d5e3a5583a69a2e30ef
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1404

-- Commit Summary --

  * Fix search history filling on GTK >= 3.20

-- File Changes --

    M src/search.c (48)

-- Patch Links --

https://github.com/geany/geany/pull/1404.patch
https://github.com/geany/geany/pull/1404.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1404
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170221/e30d065f/attachment.html>