[Github-comments] [geany/geany] Always emit the project-save signal when writing project file (#1400)

[Jiří Techet]

For some reason "project-save" isn't emitted when closing project - see
write_config(FALSE) in project_close(). This means that in this case
plugins cannot save their configuration into the config file. This doesn't
even correspond to the documentation of the signal

"Sent when a project is saved (happens when the project is created, the
 properties dialog is closed or Geany is exited)"

as the signal isnt emitted when exiting Geany because at this point Geany
closes the project.

The comment seems to indicate that the reason is that "project-save"
shouldn't be emitted when "project-close" is emitted but I don't see any
reason why.

Bump API so plugins can rely on the changed behavior.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1400

-- Commit Summary --

  * Always emit the project-save signal when writing project file

-- File Changes --

    M src/plugindata.h (2)
    M src/project.c (20)

-- Patch Links --

https://github.com/geany/geany/pull/1400.patch
https://github.com/geany/geany/pull/1400.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1400
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170218/2f165721/attachment.html>