[Github-comments] [geany/geany-plugins] addons: show color tip and start Color Chooser with double click (#664)

[Matthew Brush]

codebrainz commented on this pull request.



> +static void connect_documents_button_press_signal_handler(AoColorTip *colortip)
+{
+	guint i = 0;
+	/* connect the button-press event for all open documents */
+	foreach_document(i)
+	{
+		connect_document_button_press_signal_handler(colortip, documents[i]);
+	}
+}
+
+
+static void ao_color_tip_finalize(GObject *object)
+{
+	g_return_if_fail(object != NULL);
+	g_return_if_fail(IS_AO_COLORTIP(object));
+

I'm not familiar with Addons machinery, but I think he means when you disable this feature and this GObject instance is deleted, there will still be connections to the dangling instance pointer. You should be able to test by enabling the feature, opening a few documents, disabling the feature, and then triggering button press events on the editor widgets.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/664#discussion_r158597409
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171224/7e574b7d/attachment.html>