[Github-comments] [geany/geany-plugins] Workbench (#598)

[LarsGit223]

LarsGit223 commented on this pull request.



> + *
+ * @return The filename
+ *
+ **/
+gchar *dialogs_open_workbench(void)
+{
+    gchar *utf8_filename = NULL;
+	GtkWidget *dialog;
+	GtkFileFilter *filter;
+
+	dialog = gtk_file_chooser_dialog_new(_("Open workbench"),
+		GTK_WINDOW(wb_globals.geany_plugin->geany_data->main_widgets->window), GTK_FILE_CHOOSER_ACTION_OPEN,
+		_("_Cancel"), GTK_RESPONSE_CANCEL,
+		_("Open"), GTK_RESPONSE_ACCEPT, NULL);
+
+	filter = gtk_file_filter_new ();

Thanks, no big thing. I think if someone is committing code to an existing project it is just "good manners" to follow the coding guidelines. The core developers and maintainers of a project are the one's who most likely spent the most time on the project so I think at least the coding guidelines should be followed. If someone does not follow coding guidelines in a large way and by intention that feels a bit disrespectful to me. Also, you can read code from other people better if the style is the same among a project.

But I have to admit I would like to see projects which just say: "Use code prettifier 'xyz' with settings 'abc' and you are fine.".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/598#discussion_r134086522
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170819/9bb664d1/attachment.html>