[Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

Thomas Martitz notifications at xxxxx
Mon Apr 24 08:30:35 UTC 2017


kugel- commented on this pull request.

With this change scope does not freeze the Geany anymore. However, I was not able to enter commands in the gdb console (for which file descriptor this change is made for, right?).

> @@ -871,13 +893,24 @@ static gboolean spawn_write_cb(GIOChannel *channel, GIOCondition condition, gpoi
 }
 
 
+static gboolean spawn_read_cb(GIOChannel *channel, GIOCondition condition, gpointer data);
+
+static gboolean spawn_timeout_read_cb(gpointer data)
+{
+	SpawnChannelData *sc = (SpawnChannelData *) data;
+
+	/* The solution for continuous empty G_IO_IN-s is to generate them outselves. :) */
+	return spawn_read_cb(sc->channel, G_IO_IN, data);

Shouldn't we attempt to become a normal callback again, instead of staying on the timeout source indefinitely?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#pullrequestreview-34236359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170424/9d09fe92/attachment.html>


More information about the Github-comments mailing list