[Github-comments] [geany/geany] Added option to auto reload files changed on disk (#1246)

[shiftee]

The current state of the pull request looks like this.
```
if( buffer.is_clean )
	if( auto_reload )
		if( file_prefs.keep_edit_history_on_reload ) //default=true
			possibleHighMemoryUsage();
		else
			possibleDataLoss();
```
It looks to me like we can remove the auto_reload option and make it automatic
without data loss.

Am I correct in assuming you would prefer a finer-grained version of
file_prefs.keep_edit_history_on_reload ??

If so, perhaps document_reload_force() and document_open_file_full() could be 
refactored to take a keep_undo_history parameter??

I do not consider changing the file monitor to be a part of this PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1246#issuecomment-250536557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160929/55c29bc9/attachment.html>