[Github-comments] [geany/geany] Added option to auto reload files changed on disk (#1246)

[elextr]

On 27 September 2016 at 11:41, Matthew Brush <notifications at github.com>
wrote:

> VCS or something changed the file on disk doesn't mean I want to lose the
> buffer contents
>
> You won't lose it, it's stored in the undo history automagically.
> Moreover, in this specific case of VCS, I usually would want it to
> auto-reload since I want to be working on the correct version of the file
> (though the change notification/infobar would nag me anyway sooner or
> later).
>

​Clearly you don't accidentally checkout an old version over your changes
as often as I do :(​



> Currently you will never lose the buffer contents without your explicit
> approval.
>
> Funny, it happens to me on a daily basis :) I often accidentally press
> Ctrl+R or hit the Reload toolbar button instead of Save All button, then it
> takes me a minute to realize what happened, then I remember the change that
> removed the reload confirmation and then undo the reload. It's more like
> implicit approval :)
>

​But then I almost never do this :)​



> That said, this feature might interoperate poorly with the feature that
> stores the whole buffer change in the undo history size on reload. Imagine
> one is viewing a large log file that is being frequently written to, while
> handy to have it auto-updated in Geany, the feature storing the whole
> buffer in undo history would cause massive memory footprint (more than just
> theoretically). It might be nice to have an option to disable the storing
> of the buffer in undo history on reload, and possibly even make it mutually
> exclusive with this new option.
>

​Umm, yes, good point.  I don't think it should stop this PR since the
problem exists even if you manually allow reload a few times.  But PRs are
welcome to disable reload undo per document.​



> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/geany/geany/pull/1246#issuecomment-249744623>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AAxgTbqHDsB4j1QVScLQs4nNqAK-DFt0ks5quHQsgaJpZM4KGa-x>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1246#issuecomment-249745451
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160926/9ed5636c/attachment.html>