[Github-comments] [geany/geany] Add "project-before-close" signal to API (#1223)

Matthew Brush notifications at xxxxx
Sun Sep 18 22:34:12 UTC 2016


codebrainz commented on this pull request.



> @@ -156,6 +156,12 @@ static void create_signals(GObjectClass *g_object_class)
 		G_SIGNAL_RUN_FIRST,
 		0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
 		G_TYPE_NONE, 0);
+	geany_object_signals[GDB_PROJECT_BEFORE_CLOSE] = g_signal_new (
+		"project-before-close",
+		G_OBJECT_CLASS_TYPE (g_object_class),
+		G_SIGNAL_RUN_FIRST,
+		0, NULL, NULL, g_cclosure_marshal_VOID__VOID,
+		G_TYPE_NONE, 0);

@b4n yeah, though it would probably be nicer to actually add a new signal for that (ex. `settings-scope-changed`) than using the close signal by proxy.

Whichever you guys prefer, I'm rather indifferent. I poked around in Geany and Geany-Plugins and didn't see any problems with either approach.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160918/bbb94606/attachment-0001.html>


More information about the Github-comments mailing list