[Github-comments] [geany/geany] Proxy Plugins Filename Pattern Matching (#1236)

Matthew Brush notifications at xxxxx
Sun Sep 18 21:53:23 UTC 2016


codebrainz commented on this pull request.



> @@ -1344,6 +1347,10 @@ void plugins_init(void)
 	g_signal_connect(geany_object, "save-settings", G_CALLBACK(update_active_plugins_pref), NULL);
 	stash_group_add_string_vector(group, &active_plugins_pref, "active_plugins", NULL);
 
+	builtin_proxy_glob = g_strconcat("*.", G_MODULE_SUFFIX, NULL);
+	builtin_so_proxy.glob = g_pattern_spec_new(builtin_proxy_glob);

This would probably be better like `g_pattern_spec_new("*." G_MODULE_SUFFIX);` rather than building a dynamic string and then freeing it right away.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#pullrequestreview-483453
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160918/9e87e375/attachment-0001.html>


More information about the Github-comments mailing list