[Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

[elextr]

No, you should always know what you are setting, randomly overwriting a command that might have been set by a user, or the filetype, or the project is wrong.

You want to get the current command to see what will be executed.  

Perhaps it would have been better to return the source instead of the command, but thats 20/20 hindsight.  
But it would be a better change.  The plugin can still run rampant, just pass it to the existing setter.  But at least the plugin then has the chance to know what its doing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246256957
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160911/a14b2523/attachment.html>