[Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

Matthew Brush notifications at xxxxx
Mon Sep 12 05:02:17 UTC 2016


> Looks unnecessarily complex.

Believe it or not, the code is actually simplified since it removes an unused function and refactors an existing function to be in terms of another function instead of duplicating code. But yeah, the diff looks complex at a glance due to the way diffs work.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1225#issuecomment-246249313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160911/da87792b/attachment.html>


More information about the Github-comments mailing list