[Github-comments] [geany/geany] Plugins: Needless forward declaration of geany_load_module() (#1215)

[Matthew Brush]

I don't think this needs to be or should be defined in a public header. It was [added here](https://github.com/geany/geany/commit/721009e262e9bc279122566a60e14af0048d9094#diff-a6498e6de1fbc3174b0ce344a1e3b758R265), I suspect in order to provide documentation for it. Unless I'm mistaken, this function needn't be forward declared as it's just pulled out of the plugin DSOs using `g_module_get_symbol()`.

The reason it's an issue is two-fold. One is because it appears as though it's a public function which plugins should be able to call. More problematically, it prevents plugins from declaring it in their own way which is still compatible with the calling convention. For example, in C++ plugins, it prevents add a `noexcept` or similar specifiers because the (unused) forward declaration in the header doesn't have the same signature as the actual implementation.

I propose to move it to one of the *.dox files in the documentation directory so that it can still be documented but prevent interfering with plugins.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1215
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160905/414e5c3c/attachment.html>