[Github-comments] [geany/geany] Fix the current scope shown in the statusbar (#1280)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -2289,6 +2290,32 @@ static gint get_fold_header_after(ScintillaObject *sci, gint line)
 }
 
 
+/* returns the line after following all brace match for @brace on @line */
+static gint resolve_matching_braces(ScintillaObject *sci, gint line, gint brace)

The `brace` parameter could be a `gchar` even though it's passed an int (char constant) below, it's always ASCII `(` and compared below against a `char` returned from `sci_get_char_at()`. No big deal though, obviously, just a `gchar` is more readable since it's semantically a character and not an int (which is used in Geany for lots of other stuff, sizes, byte offsets, enums, etc).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1280#pullrequestreview-6165679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161027/0462c149/attachment.html>