[Github-comments] [geany/geany] `write_data_to_disk()` does not follow Glib advice (#1271)

Enrico Tröger notifications at xxxxx
Tue Oct 25 18:19:09 UTC 2016


> I presume @eht16 ensures no C library problems when bundles are made, but anyone building it themselves may have an issue.

Yes. The binaries and bundles provided by us should be fine as
they(Geany, GLib, GTK, Scintilla) all built the same way and all uses
the same C runtime provided by MSYS2.
I'm pretty sure no code in Geany uses mscvrt at all when Geany is built
as documented.

Of course, if anyone builds Geany with MSVC or manages to compile with
gcc but link against mscvrt or something, then strange things will happen.
I'd consider this as just not supported.

> @eht16, Why was the `g_` version used in the first place since there is no matching `g_fwrite()`?

I'm afraid there was no deeper thinking about this but rather "hey,
there is a g_ function for fopen(), so let's use this because it's
probably better than the plain one as GLib does stuff for us".
Today, I'd be rather not that naive but ten years ago, I was.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1271#issuecomment-256120529
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161025/7c86fb20/attachment.html>


More information about the Github-comments mailing list