[Github-comments] [geany/geany] Add new API function to open a project file (#1222)

Colomban Wendling notifications at xxxxx
Sun Oct 23 21:09:01 UTC 2016


b4n commented on this pull request.



> + * This is done as if the user had done it using the `Project->Open`
+ * menu item (ie. it will confirm closing the current project). Any
+ * files in the project's session will be re-opened.
+ *
+ * @param project_locale_fn The filename of the project file in locale
+ * filename encoding.
+ *
+ * @return @c TRUE if the project was opened, @c FALSE otherwise.
+ *
+ * @since 1.29 (API 230)
+ */
+GEANY_API_SYMBOL
+gboolean project_open_file(const gchar *project_locale_fn)
+{
+	return (project_ask_close() &&
+		project_load_file_with_session(project_locale_fn));

> I don't think that check is correct though. On Windows it should use `g_utf8_casefold()` because filenames are not case sensitive

Yeah probably.

>  and on all platforms it should probably use `g_utf8_collate_key_for_filename()` or similar to do a closer to "proper" comparison.

No, on non-Windows, filenames are byte sequences generally; and anyway `g_utf8_collate_key_for_filename()` is meant for sorting filenames naturally (e.g. case insensitive, human-readbale numbers, etc.), not compare for path equality.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1222
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161023/e94bef27/attachment.html>


More information about the Github-comments mailing list