[Github-comments] [geany/geany] Preventing destroying of symbolic/hard links in Windows OS. (#1270)
Matthew Brush
notifications at xxxxx
Sat Oct 22 01:27:18 UTC 2016
codebrainz commented on this pull request.
> @@ -1955,37 +1961,51 @@ static gchar *write_data_to_disk(const gchar *locale_filename,
/* Use POSIX API for unsafe saving (GVFS-unsafe) */
/* The error handling is taken from glib-2.26.0 gfileutils.c */
errno = 0;
- fp = g_fopen(locale_filename, "wb");
+ fp = g_fopen(locale_filename, "w+b"); // we can not destroy symbolic/hard links
Both "w" and "w+" truncate the file and discard it's contents (see [here](http://www.cplusplus.com/reference/cstdio/fopen/)). If you observe something else, it might be undefined behaviour. Or did I misunderstand?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1270
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161021/9f596946/attachment.html>
More information about the Github-comments
mailing list