[Github-comments] [geany/geany] Re-enable SIGTERM handling (#1255)

Matthew Brush notifications at xxxxx
Wed Oct 5 16:55:41 UTC 2016


codebrainz commented on this pull request.



>  		main_quit();
 	}
+	return G_SOURCE_REMOVE;

I wasn't sure if this should be `G_SOURCE_REMOVE` or `G_SOURCE_CONTINUE`, I guess it doesn't matter since `SIGTERM` is the only signal handled here at this point and the application will exit anyway, but in the future we might like to change the return value depending what signal was handled and what action was taken.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1255#pullrequestreview-2956077
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161005/3d60eb12/attachment.html>


More information about the Github-comments mailing list