[Github-comments] [geany/geany] Fix loading the default open encoding option (#1326)

Colomban Wendling notifications at xxxxx
Mon Nov 28 11:08:52 UTC 2016


This got broken by 907a79263d907fa354d3b4c6570f33047801dd84 back in 2011 as encoding names started to be compared more permissively, leading to "none" matching the "None" encoding.

This shouldn't be too much of a problem as trying the None encoding first should not cause any issue, but fix loading of the option anyway.

This however won't restore settings from existing configuration files that used the previous code, as there is no way to tell whether the user selected the None encoding voluntarily or not.

---

To reproduce the issue, go to the file preferences, and deactivate the *Use fixed encoding when opening non-Unicode files*.  Save the setting, and restart Geany: you'll see the setting is activated again.

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1326

-- Commit Summary --

  * Fix loading the default open encoding option

-- File Changes --

    M src/keyfile.c (4)

-- Patch Links --

https://github.com/geany/geany/pull/1326.patch
https://github.com/geany/geany/pull/1326.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1326
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161128/d83429e0/attachment.html>


More information about the Github-comments mailing list