[Github-comments] [geany/geany] Use pre-compiled 'grep' binary from MSYS2 on Windows (#1301)

[Enrico Tröger]

eht16 commented on this pull request.



> @@ -212,6 +212,10 @@ copy_grep_and_dependencies() {
 	if [ "${own_arch}" == "${ABI}" -o -z "${MSYS2_ABI_PATH}" ]; then
 		bin_dir="/usr/bin"
 	else
+		# TODO we could maybe download MSYS2 from http://www2.futureware.at/~nickoe/msys2-mirror/distrib/
+		# extract the relevant files, download "grep" from
+		# http://www2.futureware.at/~nickoe/msys2-mirror/msys/${ABI}/grep-2.XX-1-${ABI}.pkg.tar.xz
+		# and so automate this even more than requiring an existing separate MSYS installation

Yeah, but usually we build for the target ABI i686 and on my system MSYS2 is x86_64. If I would use grep.exe from my MSYS2 shell, it would be x86_64 and so not usuable for users with a 32bit Windows system.

But yeah, maybe we can even pull the dependencies from Pacman instead. I will have a look at this post-1.29.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1301
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161113/f9e0690a/attachment.html>