[Github-comments] [geany/geany] WIP: Windows (and Linux) spawn fixes (#1300)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -826,14 +988,27 @@ static gchar *prepare_run_cmd(GeanyDocument *doc, gchar **working_dir, guint cmd
 	}
 #endif
 
-	run_cmd = build_create_shellscript(*working_dir, cmd_string, autoclose, &error);
-	if (!run_cmd)
-	{
-		ui_set_statusbar(TRUE, _("Failed to execute \"%s\" (start-script could not be created: %s)"),
-			!EMPTY(cmd_string_utf8) ? cmd_string_utf8 : NULL, error->message);
-		g_error_free(error);
-		g_free(*working_dir);
-	}
+#ifdef G_OS_WIN32
+	/* Expand environment variables like %blah%. */
+	SETPTR(cmd_string, win32_expand_environment_variables(cmd_string));
+#endif
+
+	gchar *helper = g_build_filename(utils_resource_dir(RESOURCE_DIR_LIBEXEC), "geany-run-helper", NULL);

To facilitate customization, it might be nice to put a test to see if the file exists in the config dir and use the system one only if a customized one doesn't exist (as with most stuff in Geany).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1300#pullrequestreview-8303883
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161112/7beaf1c3/attachment.html>