[Github-comments] [geany/geany] Provide utf-8 command line arguments on Windows (#1258)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -1032,4 +1032,31 @@ gchar *win32_get_user_config_dir(void)
 	return g_build_filename(g_get_user_config_dir(), "geany", NULL);
 }
 
+
+void win32_make_argc_and_argv_in_utf8(gint *pargc, gchar ***pargv)

Actually recent GLib (2.40+) have `g_win32_get_command_line()` which basically does just that.

(and doesn't bother with checking for error in the conversion, so it might be "alright" -- or maybe they find it OK because they don't return arg count and expect callers to use `g_strv_length()` which that would simply truncate the list, not sure)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161109/294197a6/attachment.html>