[Github-comments] [geany/geany] Highlight fix 2 (#1039)

[Jiří Techet]

Alright, here's yet another fix of the colorization problem. I reverted the partial colorization patch completely and perform (full) recolorization when the typename list changes. I decided to detect the change of the typename list based on the string hash value - I believe it's sufficient and saves some memory per tab. The performance seems to be OK too (only when changing name of some type things get slower but there's no performance problem for normal code editing).

@elextr Could you test please?
@b4n Does it look OK to you?
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1039

-- Commit Summary --

  * Revert "Colourise only the visible area when highlighting typenames"
  * Don't accumulate multiple colourises
  * Perform typename re-colourisation only when typename list changes

-- File Changes --

    M src/document.c (22)
    M src/documentprivate.h (2)
    M src/editor.c (26)

-- Patch Links --

https://github.com/geany/geany/pull/1039.patch
https://github.com/geany/geany/pull/1039.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160518/37e8345b/attachment.html>