[Github-comments] [geany/geany] Gi signals (#1038)

[Thomas Martitz]

Am 17.05.2016 um 02:40 schrieb Matthew Brush:
> IMO, we shouldn't abuse GBoxed like that. Would be better to fix
> upstream to work properly than spread bug-generating hacks all over.
> Isn't there also some kind of annotation comment that can be used to
> hint gir-scanner that the parameter is just a raw pointer with a
> |G_TYPE_POINTER|?
>

Using G_TYPE_POINTER subtypes has absolutely no benefit, apart from 
being slightly "prettier" from a design POV.

However, you know upstream bug report[1] which is largely ignored. I've 
been told that if I want this fixed I've got to do it myself. GI* stuff 
is largely in maintainace mode with little development.

I've looked into the code and I won't be able to implement this support 
any time soon. It's really a lot of code to change.

And then it would have to be reviewed and accepted which would take 
months, and then years before the fixed program versions reach users 
through updated packages.

Since there is no technical benefit I don't see the point of investing 
so much of my time into that and delay deployment of my peasy plugin for 
some years.

> I'm not super fond of exposing the GeanyObject either. IMO, if it /must/
> be exported to make this work, we shouldn't add Doxygen comments so it
> remains "private" and we can drop at will whenever we get around to
> moving those signals to the correct objects.
>

Why that? My peasy plugin is a normal plugin and wants to use standard 
Geany APIs. I thought if plugins require new APIs we consider adding them?

Are there specific plans to "moving those signals to the correct 
objects"? These object don't even exist. Unless there are plans to 
change the status quo in the near future I think we should just expose 
what we've got currently.

> I think this PR also depends on changes that are being worked on
> upstream, so the Travis builds fail.
>

That was a mistake and is corrected now. The travis build still fails, 
I'll check that later.



---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1038#issuecomment-219690234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160517/d0ba4e7e/attachment.html>