[Github-comments] [geany/geany] TM cleanups (#957)

[Jiří Techet]

> @@ -109,6 +109,35 @@ gchar *tm_get_real_path(const gchar *file_name)
>  	return NULL;
>  }
>  
> +/* add argument list of __init__() Python methods to the class tag */
> +static void update_python_arglist(const TMTag *tag)

But if you have a look how it's done now, it's much worse and much more unmaintainable than this - it introduces diff to the python parser compared to universal-ctags and worse, it makes a very strange direct path python_parser->TM (no other parser does this, all of them generate tags the standard way).

Such a strange callback would definitely not become part of ctags API if it's ever turned into a library so we'd have to maintain our own version. The "just one more" is very well justified in this case IMO (other option is not to add the constructor parameters to the class type and drop this feature).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957/files/f61a64be29cbba0162f92eb5c1fe4aa2af33fd33#r62033361
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160504/325a96d7/attachment.html>