[Github-comments] [geany] TM cleanups (#957)

Jiří Techet notifications at xxxxx
Thu Mar 10 17:41:07 UTC 2016


This is hopefully the last "big" patch set related to TM. In fact, despite the diff size, it's actually not that big - the diffs are mostly caused by moving stuff around.

There are no functional changes in this patch set - just cleanups.

Most of the patches concentrate on TM<-->ctags interaction and simplification of their interfaces.

The last patch is an API/ABI break affecting projectorganizer and geanyprj - probably not worth the break alone but if there are more patches requiring ABI break, this one could be added. Can remove it from this patch set and submit separately.

It would be nice to have it applied early-ish in the 1.28 cycle as I'd like to do some work on syncing with upstream universal-ctags which will depend on these patches.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/957

-- Commit Summary --

  * Remove the TagEntrySetArglistFunction hook
  * Initialize ctags at a single place instead of four
  * Improve ctags callback API
  * Use G_BEGIN_DECLS/G_END_DECLS
  * Remove unused tm_tagmanager.h
  * Move code related to various tag file formats into tm_source_file.c
  * Add an API-like ctags layer
  * Use TMParserType instead of language name in tm_source_file_new()
  * Clean up messy tm_workspace_create_global_tags()
  * Remove some unused return values and unnecessary checks

-- File Changes --

    M src/document.c (5)
    M tagmanager/ctags/entry.c (8)
    M tagmanager/ctags/entry.h (1)
    M tagmanager/ctags/parse.c (9)
    M tagmanager/ctags/parse.h (7)
    M tagmanager/ctags/python.c (30)
    M tagmanager/src/Makefile.am (6)
    A tagmanager/src/tm_ctags_wrappers.c (113)
    A tagmanager/src/tm_ctags_wrappers.h (47)
    M tagmanager/src/tm_source_file.c (806)
    M tagmanager/src/tm_source_file.h (24)
    M tagmanager/src/tm_tag.c (559)
    M tagmanager/src/tm_tag.h (38)
    D tagmanager/src/tm_tagmanager.h (39)
    M tagmanager/src/tm_workspace.c (373)
    M tagmanager/src/tm_workspace.h (9)
    M wscript (1)

-- Patch Links --

https://github.com/geany/geany/pull/957.patch
https://github.com/geany/geany/pull/957.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160310/cf8cda18/attachment.html>


More information about the Github-comments mailing list