[Github-comments] [geany-plugins] scope: Ignore a false positive from cppcheck (#397)

Colomban Wendling notifications at xxxxx
Thu Mar 10 01:12:46 UTC 2016


If you want to "fix" the issue, I guess you could do that (untested):
```diff
diff --git a/scope/src/store/scptreestore.c b/scope/src/store/scptreestore.c
index 4ee0f45..c659560 100644
--- a/scope/src/store/scptreestore.c
+++ b/scope/src/store/scptreestore.c
@@ -906,7 +906,7 @@ GtkTreePath *scp_tree_store_get_path(VALIDATE_ONLY ScpTreeStore *store, GtkTreeI
        {
                gtk_tree_path_append_index(path, ITER_INDEX(iter));
 
-               while ((elem = elem->parent), elem->parent)
+               for (elem = elem->parent; elem->parent; elem = elem->parent)
                {
                        gint index = scp_ptr_array_find(elem->parent->children, elem);
 
```
But that's not a but so…

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/397#issuecomment-194601384
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160309/922a4951/attachment.html>


More information about the Github-comments mailing list