[Github-comments] [geany] Gi sci methods v2 (#948)

Colomban Wendling notifications at xxxxx
Wed Mar 9 20:41:28 UTC 2016


>      try:
>          outfile.write("/*\n * Automatically generated file - do not edit\n */\n\n")
> -        outfile.write("#include <glib.h>\n")
> -        outfile.write("#include <gtk/gtk.h>\n\n")
> -        outfile.write("typedef struct _ScintillaObject ScintillaObject;\n")
> +        outfile.write("#include \"gtkcompat.h\"\n")
> +        outfile.write("#include \"sciwrappers.h\"\n")

> Oh, and I'm not sure about "" vs <>. I doubt it makes a difference, as IIUC g-ir-scanner doesn't have default or system include directories but only those you mention in CFLAGS.

Well, I ask because I saw recently an old cppcheck treating those differently in some situations.  It's fragile, but not totally absurd as a `""`-included header will give precedence in a file next to the including one, while a `<>` one will give precedence to a system header.  But I guess they don't do that.

So well, while it could get problematic I guess relying on the actual behavior is fine enough.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/948/files#r55585289
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160309/1bc18c70/attachment.html>


More information about the Github-comments mailing list