[Github-comments] [geany] Gi sci methods v2 (#948)

[Thomas Martitz]

>      try:
>          outfile.write("/*\n * Automatically generated file - do not edit\n */\n\n")
> -        outfile.write("#include <glib.h>\n")
> -        outfile.write("#include <gtk/gtk.h>\n\n")
> -        outfile.write("typedef struct _ScintillaObject ScintillaObject;\n")
> +        outfile.write("#include \"gtkcompat.h\"\n")
> +        outfile.write("#include \"sciwrappers.h\"\n")

Am 9. März 2016 19:35:54 MEZ, schrieb Colomban Wendling <notifications at github.com>:
>>      try:
>>          outfile.write("/*\n * Automatically generated file - do not
>edit\n */\n\n")
>> -        outfile.write("#include <glib.h>\n")
>> -        outfile.write("#include <gtk/gtk.h>\n\n")
>> -        outfile.write("typedef struct _ScintillaObject
>ScintillaObject;\n")
>> +        outfile.write("#include \"gtkcompat.h\"\n")
>> +        outfile.write("#include \"sciwrappers.h\"\n")
>
>Why include sciwrappers here?  wouldn't it make more sense to include
>`Scintilla.h` and `ScintillaWidget.h`?
>Anyway, good point including *gtkcompat.h* for the GtkComboBoxText
>hack.  Though, now we depend on 2.24 I'd like to break API and ABI and
>drop the compat here at some point.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/geany/geany/pull/948/files#r55565475

Convenience, mostly. g-ir-scanner doesnt scam includes but uses type information from them if they are used in the main file. Only symbols defined in the files listed in the cmdline are picked up.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/948/files#r55566379
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160309/e2ec5e6c/attachment.html>