[Github-comments] [geany] Gi sci methods v2 (#948)

[Colomban Wendling]

>      try:
>          outfile.write("/*\n * Automatically generated file - do not edit\n */\n\n")
> -        outfile.write("#include <glib.h>\n")
> -        outfile.write("#include <gtk/gtk.h>\n\n")
> -        outfile.write("typedef struct _ScintillaObject ScintillaObject;\n")
> +        outfile.write("#include \"gtkcompat.h\"\n")
> +        outfile.write("#include \"sciwrappers.h\"\n")

Why include sciwrappers here?  wouldn't it make more sense to include `Scintilla.h` and `ScintillaWidget.h`?
Anyway, good point including *gtkcompat.h* for the GtkComboBoxText hack.  Though, now we depend on 2.24 I'd like to break API and ABI and drop the compat here at some point.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/948/files#r55565475
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160309/bd8b258e/attachment.html>