[Github-comments] [geany-plugins] spellcheck: Use <> to include Geany headers (#393)

[Colomban Wendling]

> Still being curious: where is the typo you mentioned? In the diff? In the title of this PR, then it is not fixed :).

It was the commit message, but I forgot to update the title (which was autogenerated from the commit) :)

> And more related to the changes themselves: shouldn't other plugins which use `#include "geanyplugin.h"` also be affected? Or is there something special in SpellCheck from `cppcheck`'s POV?

Apparently other plugins are not affected, yet I can't really tell you why.  All I can guess is that, as stated in the commit message, when you pass defines options to cppheck (`-Dsomething`) it starts requiring all `""` headers to be found -- maybe it tries running a preprocessor or something in this case?  As SpellCheck is the only plugin passing a `-D` option to cppcheck, it's the only one affected.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/393#issuecomment-193734149
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160308/ec6665b2/attachment.html>