[Github-comments] [geany] Avoid NULL dereference when typing a dot in a file without tags (#943)
Colomban Wendling
notifications at xxxxx
Mon Mar 7 14:50:49 UTC 2016
@techee `NULL` check was removed in 292383c197b72c56f44b68b14845093adfed7133, was that really expected?
Other solution would be early return in `autocomplete_scope()` when `doc->tm_file` is `NULL`, but that would mean that there wouldn't be scope completion in unsaved files.
We need a fix ASAP, as it happens whenever typing `.` in an unsaved file, or a file with no tags parser. E.g. you can reproduce by opening a new geany `geany -vi` and typing `a.`, *boom*.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/943
-- Commit Summary --
* Avoid NULL dereference when typing a dot in a file without tags
-- File Changes --
M tagmanager/src/tm_workspace.c (2)
-- Patch Links --
https://github.com/geany/geany/pull/943.patch
https://github.com/geany/geany/pull/943.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160307/48c4ebf9/attachment.html>
More information about the Github-comments
mailing list