[Github-comments] [geany] Deprecate filetype_id (#932)

Colomban Wendling notifications at xxxxx
Sat Mar 5 19:33:09 UTC 2016


@codebrainz yeah there's quite a few places where we should use the typedef rather than `gint`/`guint`, I made a commit for that right after these, but didn't include it as I didn't necessarily check properly enough whether there might be side effects (I doubt it, but still).  I left public API alone in my case, but yeah ultimately we should use the typedef in public functions too.  There's however a few specific locations where we can't use the typedef because we use `-1` as "not chosen" (i.e. in the file open dialog).
Anyway, I think I'd rather do this part after the release, esp. for the internal changes.

@kugel- it wasn't in the version right before this change, that's why I ask.  But it's not documented so I guess it should get ignored just fine.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/932#issuecomment-192713348
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160305/065211ad/attachment.html>


More information about the Github-comments mailing list