[Github-comments] [geany] Don't show the goto popup for typedef synonyms (#923)

[Jiří Techet]

@b4n What about an imperfect (but simple) patch now and a bigger patch (possibly rewriting quite a big portion of the function) after the release? I've updated the patch so that I just removed the part of the code removing tags from the current line from the popup result (this guarantees that if there were >0 tags before the filtering, there will be >0 tags after it which is necessary for the declaration goto). The thing the patch does now is it just removes one of the two identical names one of which is typedef.

How do you feel about this? (For me the popup is one of the highlights of the next release so I'd feel a bit sorry to get it removed - but nothing tragic so I'll leave it up to you.)

Doing this properly will be indeed quite some work and definitely not for the next release. When we Ctrl+click a symbol on the current line we should decide if we want to do goto definition or declaration in case we have tags for both of them (I guess we should do the declaration jump), possibly distinguish functions based on their parameters when swapping to declaration, etc. Maybe it could be based on your patch - I didn't study it in greater detail but I like you removed the recursive call which makes things more and more complicated as the function is getting more complex.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/923#issuecomment-192618283
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160305/91716c8b/attachment.html>