[Github-comments] [geany/geany] Windows: Convert working directory to locale encoding before spawning commands (#1095)

[Colomban Wendling]

> Still I think, this place is not that wrong, at least on Windows, because usually we say: "use `utils_get_locale_from_utf8` everywhere!" and on Windows this is just a no-op. This is OK for almost all places, especially when dealing with filenames and the GLib file API.

Yes, it's true that as GLib uses "filename encoding" in most OS-related places, it makes some sense.  It's unfortunate we have our helpers named "locale", which is a lie on Windows.

So yeah having an API accepting "filename encoding" might be nice, although @elextr's pint is also valid: we probably should provide an UTF-8-based API that does everything.  Although it's still annoying in come corner cases when we get things in filename or locale encoding from other places.

But do we want to modify the current one or add variants?
Also, this affects all four input parameters: working directory, command line, argv and environment.  All these need to be converted as appropriate.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1095#issuecomment-229125519
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160628/1bba23cc/attachment.html>