[Github-comments] [geany/geany] Windows: Convert working directory to locale encoding before spawning commands (#1095)

[Colomban Wendling]

Actually, the current state (in master) is terrible.  For example, our use of the environment is plain wrong regarding the encodings: we get the environment in "GLib filename encoding" (that is, UTF-8 on windows, locale otherwise), but we add UTF-8 values to it and pass it to various functions.  This *was* right on Windows when we used `g_spawn_*()`, but it's wrong now.  And on non-Windows, it was always wrong (and we do the same with VTE API, same problem).

Same problem with most (but not all) other arguments, where we just used to dump UTF-8 and hope.  Again, it appeared to work because the Windows part used UTF-8, and other platforms generally use UTF-8 as the locale so we can confuse it just fine.

So yeah, we broke stuff, especially on Windows.  But it's actually wrong all over the place, with *some* places where it's right.

I'll try to sort those out but well.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1095#issuecomment-229052287
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160628/b9d2ede0/attachment.html>