[Github-comments] [geany/geany] Windows: Convert working directory to locale encoding before spawning commands (#1095)

[Colomban Wendling]

> @b4n since there are multiple callers of spawn that means that multiple places need #if win32 and then to do the conversions to locale.

The conversion need not be conditional, as as I said *all* platforms expect a locale string.  We just don't see to many issues because most non-Windows use UTF-8 as the locale, so the conversion would actually be a no-op, but that doesn't mean it's right.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1095#issuecomment-228914151
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160627/9e46ab76/attachment.html>