[Github-comments] [geany/geany-plugins] Dangerous use of undo grouping (#455)

[Colomban Wendling]

GeanyLatex may (at least technically, but I think it's a real bug) start an undo action an never end it.  This could break Geany's whole undoing capability when triggered.

The incriminated code is in `glatex_structure_lvlup()`: an undo action is started unconditionally, but ended conditionally.  That is, if `utils_string_replace_all()` returns 0 replacement for all `GLATEX_STRUCTURE`s, the undo grouping won't be ended.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/455
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160625/fc802e8d/attachment.html>