[Github-comments] [geany/geany] tagmanager: Fix UB around sequencing of side effects (#1074)

Colomban Wendling notifications at xxxxx
Thu Jun 23 17:53:37 UTC 2016


It'd be better to get a similar "fix" in universal-ctags not to diverge too further (and not to get it back when we start using uctags).

Though, as @elextr this actually isn't really a problem AFAIK, no UB here.  But as he said, I agree it'd be more readable (at least `while ((c = getcFromInputFile ()) != EOF && isident (c));` instead of using the comma operator here).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1074#issuecomment-228129345
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160623/e758f8b2/attachment.html>


More information about the Github-comments mailing list