[Github-comments] [geany/geany] Fix undo of line end type change (#527)

[Jiří Techet]

> +void ui_update_menu_eol(GeanyDocument *doc)
> +{
> +	gint eol = sci_get_eol_mode(doc->editor->sci);
> +	const gchar *widget_name;
> +
> +	switch (eol)
> +	{
> +		case SC_EOL_CR: widget_name = "cr"; break;
> +		case SC_EOL_LF: widget_name = "lf"; break;
> +		default: widget_name = "crlf"; break;
> +	}
> +	gtk_check_menu_item_set_active(
> +		GTK_CHECK_MENU_ITEM(ui_lookup_widget(main_widgets.window, widget_name)), TRUE);
> +
> +	ui_update_statusbar(doc, -1);
> +}

There was nothing really deep behind this - just pure laziness - I basically just copied what was in UNDO_ENCODING. Looking at it you are right, this is unnecessary.

To make things consistent I added a similar patch for UNDO_ENCODING too.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/527/files/6a2422af3226738247284ef8f1154a8e23bfca9f#r68266979
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160623/8c317b60/attachment.html>