[Github-comments] [geany/geany] Gi signals (#1038)

[Matthew Brush]

> @@ -3250,6 +3250,7 @@ void scintilla_release_resources(void) {
>  static void *copy_(void *src) { return src; }
>  static void free_(void *doc) { }
>  
> +GEANY_API_SYMBOL
>  GType scnotification_get_type(void) {
>  	static gsize type_id = 0;

I think mentioned this before (maybe on scintilla-interest?), but I don't think there's any point using `gsize` here and keeping casting from `GType` to `gsize`. I think you can just use `GType` everywhere here (or use `gsize` without the casts). Not a big deal, but casts are kind of gross, and could cause subtle bugs if/when `GType` is ever not the same as `gsize`. No biggie though, it's not our code :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1038/files/6b5a47d05f575b321ff158044420864ee9e59889#r68159303
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160622/e3399dc9/attachment.html>