[Github-comments] [geany/geany-plugins] projectorganizer: Fix multiple tabs in Project Properties (#448)

Jiří Techet notifications at xxxxx
Wed Jun 15 14:20:46 UTC 2016


There is a problem when there are multiple tabs added by plugins: if
on_project_dialog_open() is called and Project Organizer stores
the index of the tab and then another plugin adds a tab before the
Project Organizer's tab, then the stored index becomes invalid which
can lead to not correctly removing the tab from the dialog.

Instead store a pointer of the added tab widget and remove the widget
when the properties dialog is closed.

Fixes #444 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/448

-- Commit Summary --

  * projectorganizer: Fix multiple tabs in Project Properties

-- File Changes --

    M projectorganizer/src/prjorg-main.c (12)
    M projectorganizer/src/prjorg-project.c (7)
    M projectorganizer/src/prjorg-project.h (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/448.patch
https://github.com/geany/geany-plugins/pull/448.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160615/9eac7b24/attachment.html>


More information about the Github-comments mailing list