[Github-comments] [geany/geany] Improve Goto Symbol popup contents (#958)

[Colomban Wendling]

> @@ -2071,102 +2071,114 @@ static TMTag *find_best_goto_tag(GeanyDocument *doc, GPtrArray *tags)
>  }
>  
>  
> +static GPtrArray *filter_tags(GPtrArray *tags, TMTag *current_tag, gboolean definition)
> +{
> +	const TMTagType forward_types = tm_tag_prototype_t | tm_tag_externvar_t;
> +	TMTag *tmtag, *last_tag = NULL;
> +	GPtrArray *filtered_tags = g_ptr_array_new();
> +	guint i;
> +
> +	foreach_ptr_array(tmtag, i, tags)
> +	{
> +		if (definition && !(tmtag->type & forward_types) ||
> +			!definition && (tmtag->type & forward_types))

GCC suggests parentheses, and while the indention is fairly clear, I think it's still a good idea.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/958/files/65f84df5cae544deaf3a4ca56c7f29d8e13329d3#r66337142
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160608/80b96a5f/attachment.html>